fix: ensure classic computed chains support #8432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added a commit
that referenced
this pull request
Feb 27, 2023
* adds tests and gets tests passing lols * simplify working version * more fixes * reduce private api abuse * fixes * restore worse private api use :( * fix deprecation scenario * fix dep stripped * fix lint
runspired
added a commit
that referenced
this pull request
Feb 27, 2023
* adds tests and gets tests passing lols * simplify working version * more fixes * reduce private api abuse * fixes * restore worse private api use :( * fix deprecation scenario * fix dep stripped * fix lint
runspired
added a commit
that referenced
this pull request
Feb 27, 2023
runspired
added a commit
that referenced
this pull request
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests and a fix for computed chains not updating in EmberData 4.8+.
This fix relies on using private APIs within
@glimmer/validatorand@ember/-internals/metalin order to fix emberjs/ember.js#20386. The fix works by forcing creation and entanglement of the special[]andlengthtags that array prototype extensions typically provide.resolves #8411
resolves #8431