Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (internal): support legacy model behaviors in SchemaRecord legacy mode #9095

Merged
merged 15 commits into from
Nov 11, 2023

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Nov 9, 2023

  • id
  • constructor.modelName
  • currentState
  • errors
  • state flags
  • object lifecycle flags
  • serialize
  • _createSnapshot
  • reload
  • changedAttributes
  • rollbackAttributes
  • unloadRecord
  • deleteRecord
  • save
  • belongsTo references
  • hasMany references
  • destroyRecord

Tests

  • id
  • constructor.modelName
  • currentState
  • errors
  • state flags
  • object lifecycle flags
  • serialize
  • _createSnapshot
  • reload
  • changedAttributes
  • rollbackAttributes
  • unloadRecord
  • deleteRecord
  • save
  • [-] belongsTo references (test once legacy belongsTo support is done)
  • [-] hasMany references (test once legacy hasMany support is done)
  • destroyRecord

TBD

  • schema methods on instance
  • schema methods on constructor

Note: only superficially tested. We're largely just copying model code over in a non-diverging manner so as long as the basic mechanics work we should be fine. So for instance we don't need to test every behavior around state flags.

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels Nov 9, 2023
@runspired runspired merged commit 73f7ae6 into main Nov 11, 2023
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the schema-record/legacy-features branch November 11, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant