Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure cache-handler clones full errors #9383

Merged
merged 14 commits into from
Apr 25, 2024
Merged

fix: ensure cache-handler clones full errors #9383

merged 14 commits into from
Apr 25, 2024

Conversation

runspired
Copy link
Contributor

Fixes an external report that surfaced that the CacheHandler would discard much of the useful error when cloning to prevent mutation.

@runspired runspired added 🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue lts-4-12 Long Term LTS Maintenance labels Apr 24, 2024
@runspired runspired self-assigned this Apr 24, 2024
@runspired runspired merged commit 053d70b into main Apr 25, 2024
17 of 18 checks passed
@runspired runspired deleted the fix-error-propagation branch April 25, 2024 06:15
@gitKrystan gitKrystan mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baltazore Baltazore Baltazore left review comments

Assignees

@runspired runspired

Labels
🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue lts-4-12 Long Term LTS Maintenance
Projects
EmberData
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@runspired @Baltazore