feat: implement schema-object for schema-record #9467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richgt
force-pushed
the
richgt/schema-object-take-2
branch
from
8d6de47
to
70dcbe3
Compare
runspired
reviewed
Jun 10, 2024
|
|
||
| if (prop === 'toHTML') { | ||
| return function () { | ||
| return '<div>ManagedObject</div>'; |
There was a problem hiding this comment.
follow up: probably just leave it a string along the lines of [ManagedObject<${address.type}:${address.id} (${address.lid})>]
runspired
approved these changes
Jun 10, 2024
runspired
added
🎯 canary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements schema-object features in keeping with definitions in the Schema Service RFC.
Notes for the release