Skip to content

Commit

Permalink
Remove automated uploads (#2103)
Browse files Browse the repository at this point in the history
  • Loading branch information
RobbieTheWagner committed Aug 17, 2022
1 parent 14ad059 commit 7226e2c
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 62 deletions.
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,11 @@ Here are the steps to lock an inspector version:
- Create a new branch (from `stable`) named after the Ember version range that will be supported by this branch. The min version in the range is the first element in the `emberVersionsSupported` array in `package.json`. The max version in the range is the first version that will *not* be supported. For example, a branch named `ember-0.0.0-2.7.0` means it supports Ember 0.0.0 -> 2.6.0, and a branch named `ember-2.7.0-3.4.0` means it supports Ember 2.7.0 -> Ember 3.3.2.
- Update `package.json`'s `emberVersionsSupported`: add a second element that indicates the minimum Ember version the `master` branch *will not* support.
- Commit the branch.
- Run `yarn lock-version`. This will build, compress, and upload this version to S3.
- Run `yarn lock-version`. This will build, and compress the panes.
- To upload the panes to GitHub:
- Create a folder locally with the naming convention `panes-x-x-x`
- Copy the 3 zip files (chrome.zip, firefox.zip, and bookmarklet.zip) into the folder you just created.
- Go to https://github.com/emberjs/ember-inspector/upload/panes and drag the folder in to upload it.
- Checkout the `master` branch.
- Update `package.json`'s `previousEmberVersionsSupported`: add the first Ember version supported by the recently locked snapshot (the first element in the `emberVersionsSupported` array).
- Update `package.json`'s `emberVersionsSupported`: Take the last element from `previousEmberVersionsSupported` and set it as the first element in this array. Set an empty string as the second element to indicate there's currently no maximum Ember version supported yet. `emberVersionsSupported` array length should always be `2` indicating a [min, max] range.
Expand Down
6 changes: 3 additions & 3 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ exports['compress:chrome'] = () =>
exports['compress:firefox'] = () =>
compress('dist/firefox', 'firefox/ember-inspector.zip');
exports['compress:chrome-pane'] = () =>
compress(`dist/chrome/${versionedPane}`, 'chrome-pane.zip');
compress(`dist/chrome/${versionedPane}`, 'chrome.zip');
exports['compress:firefox-pane'] = () =>
compress(`dist/firefox/${versionedPane}`, 'firefox-pane.zip');
compress(`dist/firefox/${versionedPane}`, 'firefox.zip');
exports['compress:bookmarklet-pane'] = () =>
compress(`dist/bookmarklet/${versionedPane}`, 'bookmarklet-pane.zip');
compress(`dist/bookmarklet/${versionedPane}`, 'bookmarklet.zip');

exports['clean-tmp'] = () => del('./tmp');
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,12 @@
"lint:hbs": "ember-template-lint .",
"lint:hbs:fix": "ember-template-lint . --fix",
"lint:js": "eslint . --cache",
"lock-version": "yarn build:production && yarn compress:panes && EMBER_ENV=production node scripts/upload-panes.js",
"lock-version": "yarn build:production && yarn compress:panes",
"serve:bookmarklet": "ember serve --port 9191",
"lint:js:fix": "eslint . --fix",
"start": "ember serve",
"test": "npm-run-all lint test:*",
"test:ember": "COVERAGE=true ember test",
"upload:panes": "yarn build && yarn compress:panes && node scripts/upload-panes.js",
"watch": "ember build --watch"
},
"devDependencies": {
Expand Down
56 changes: 0 additions & 56 deletions scripts/upload-panes.js

This file was deleted.

0 comments on commit 7226e2c

Please sign in to comment.