Skip to content

Commit

Permalink
replace Ember.copy, merge w/ Object.assign (#835)
Browse files Browse the repository at this point in the history
  • Loading branch information
bgentry authored and RobbieTheWagner committed Jul 25, 2018
1 parent 89c31b3 commit c393f0e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
3 changes: 1 addition & 2 deletions app/libs/promise-assembler.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { assert } from '@ember/debug';
import { copy } from '@ember/object/internals';
import { later } from '@ember/runloop';
import EmberObject, { computed } from '@ember/object';
import EventedMixin from '@ember/object/evented';
Expand Down Expand Up @@ -68,7 +67,7 @@ export default EmberObject.extend(EventedMixin, {

rebuildPromises(promises) {
promises.forEach(props => {
props = copy(props);
props = Object.assign({}, props);
let childrenIds = props.children;
let parentId = props.parent;
delete props.children;
Expand Down
4 changes: 1 addition & 3 deletions app/libs/resizable-columns.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
import { set } from '@ember/object';

import { isNone } from '@ember/utils';
import { copy } from '@ember/object/internals';
import { merge } from '@ember/polyfills';
import compareArrays from 'ember-inspector/utils/compare-arrays';

const { floor } = Math;
Expand Down Expand Up @@ -193,7 +191,7 @@ export default class {
if (this._columnVisibility) {
return this._columnVisibility;
}
this._columnVisibility = this.columnSchema.map(column => merge(copy(column), {
this._columnVisibility = this.columnSchema.map(column => Object.assign({}, column, {
visible: this.isColumnVisible(column.id)
}));
}
Expand Down
4 changes: 2 additions & 2 deletions ember_debug/libs/promise-assembler.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import Promise from 'ember-debug/models/promise';
const Ember = window.Ember;
const { Object: EmberObject, Evented, A, computed, RSVP, copy, isNone } = Ember;
const { Object: EmberObject, Evented, A, computed, RSVP, isNone } = Ember;

let PromiseAssembler = EmberObject.extend(Evented, {
// RSVP lib to debug
Expand Down Expand Up @@ -95,7 +95,7 @@ let PromiseAssembler = EmberObject.extend(Evented, {
if (entry) {
entry.setProperties(properties);
} else {
properties = copy(properties);
properties = Object.assign({}, properties);
properties.guid = guid;
entry = this.createPromise(properties);
}
Expand Down

0 comments on commit c393f0e

Please sign in to comment.