Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Inspector (3.12.2) to view a particular Component or Data Model record fails with the following error: #1068

Closed
iofusion opened this issue Nov 8, 2019 · 8 comments · Fixed by #1072

Comments

@iofusion
Copy link

iofusion commented Nov 8, 2019

Ember : 3.11.1
Ember Data : 3.11.4
Inspector : 3.12.2
Chrome Version 80.0.3963.0 (Official Build) canary (64-bit)

Inspecting a Component, Data Model Record or Container results in:

Ember Inspector has errored.
This is likely a bug in the inspector itself.
You can report bugs at https://github.com/emberjs/ember-inspector.
Error message: glimmer.value is not a function
Stack trace: TypeError: glimmer.value is not a function
at :3551:42
at Array.forEach ()
at :3531:24
at Array.forEach ()
at calculateCPs (:3530:18)
at Class.mixinsForObject (:3254:7)
at Class.sendObject (:3068:26)
at Class.inspectById (:2990:16)
at sendEvent (http://localhost:4200/assets/vendor.js:30041:14)
at Class.trigger (http://localhost:4200/assets/vendor.js:44727:28)

@chancancode
Copy link
Member

This is introduced in #1035, @pzuraq @patricklx do you mind taking a look?

@RobbieTheWagner
Copy link
Member

@iofusion do you have an app we could reproduce this error on?

@RobbieTheWagner
Copy link
Member

This can be reproduced by clicking something in the data tab and trying to inspect it, as talked about in this duplicate issue #1071.

wycats pushed a commit that referenced this issue Nov 9, 2019
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see #1068 and #1071.
wycats pushed a commit that referenced this issue Nov 9, 2019
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see #1068 and #1071.
wycats pushed a commit that referenced this issue Nov 9, 2019
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see #1068 and #1071.
wycats pushed a commit that referenced this issue Nov 9, 2019
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see #1068 and #1071.
wycats pushed a commit that referenced this issue Nov 9, 2019
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see #1068 and #1071.
wycats pushed a commit that referenced this issue Nov 9, 2019
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see #1068 and #1071.
wycats pushed a commit that referenced this issue Nov 9, 2019
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see #1068 and #1071.
wycats pushed a commit that referenced this issue Nov 9, 2019
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see #1068 and #1071.

(cherry picked from commit 2645d33)
wycats pushed a commit that referenced this issue Nov 9, 2019
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see #1068 and #1071.
@patricklx
Copy link
Collaborator

patricklx commented Nov 9, 2019

Looks like we need one more check for glimmer.value

tagInfo.revision = glimmer.value(object, item.name);

Though is it strange that there is metal.track but not glimmer?

Edit: looks like older ember version didn't have .value function.
https://github.com/emberjs/ember.js/blob/v3.11.1/packages/@ember/-internals/glimmer/lib/utils/references.ts#L16
Any alternative?

@enspandi
Copy link

Same here - just appeared this morning with latest update.

@kumkanillam
Copy link

I am also getting the same error in the latest 3.12.2 version of the ember inspector.

VM46:92 Ember Inspector has errored.
This is likely a bug in the inspector itself.
You can report bugs at https://github.com/emberjs/ember-inspector.
Error message: glimmer.value is not a function
Stack trace: TypeError: glimmer.value is not a function
    at <anonymous>:3551:42
    at Array.forEach (<anonymous>)
    at <anonymous>:3531:24
    at Array.forEach (<anonymous>)
    at calculateCPs (<anonymous>:3530:18)
    at Class.mixinsForObject (<anonymous>:3254:7)
    at Class.sendObject (<anonymous>:3068:26)
    at Class.inspectById (<anonymous>:2990:16)
    at sendEvent (http://localhost/assets/vendor.js:36714:14)
    at Class.trigger (http://localhost/assets/vendor.js:51185:28)

@iofusion
Copy link
Author

@kumkanillam #1072 fixes this issue, but that update was not available in the Chrome extension store last I checked. There are instruction in this repo's readMe for installing manually.

@pjcarly
Copy link

pjcarly commented Nov 12, 2019

There hasn't been a new release yet. So I guess that is normal

wycats pushed a commit that referenced this issue Nov 12, 2019
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see #1068 and #1071.
wycats pushed a commit that referenced this issue Nov 12, 2019
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see #1068 and #1071.
wycats pushed a commit that referenced this issue Nov 13, 2019
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see #1068 and #1071.
wycats pushed a commit that referenced this issue Nov 13, 2019
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see #1068 and #1071.

(cherry picked from commit 63f9a6b)
nummi pushed a commit to nummi/ember-inspector that referenced this issue Apr 1, 2020
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see emberjs#1068 and emberjs#1071.
nummi pushed a commit to nummi/ember-inspector that referenced this issue Apr 5, 2020
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see emberjs#1068 and emberjs#1071.
patricklx pushed a commit to patricklx/ember-inspector that referenced this issue Sep 19, 2022
Also add ember-lts-3.12 to CI matrix, however, 3.12 is currently
failing, see emberjs#1068 and emberjs#1071.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants