injected script breaks browser default XML presentation

[ghost]

As a developer, I use web-browsers to visually inspect XML. Ember inspector injects a script tag that breaks the default browser presentation of the XML.

Issue and Steps to Reproduce

• navigate to https://blog.emberjs.com/feed.xml in Firefox
• Observe how the page appears as plaintext instead of formatted XML

I believe this occurs because we indiscriminately append the boot <script>:

ember-inspector/skeletons/web-extension/boot.js

Line 3 in 4713877

// TODO: make this conditional, only do it when requested.

Screenshots

unexpected

expected

[chancancode]

Hm we should definitely check the document type and inject it conditionally!

[RobbieTheWagner]

@chancancode better yet, we should only run inspector when you click the inspector tab.

[chancancode]

As things are designed today, this particular script tag has to be injected eagerly to allow the inspector to possibly run later. We can add UI to change which sites to run on, but unless we require a refresh to activate the inspector this isn’t really avoidable at the moment.

[RobbieTheWagner]

@chancancode yeah not sure if there is a good solution, but it would be ideal. There have been several reports of this breaking non-Ember sites in some way.

[ghost]

For this case, I'm entirely happy with inferring the mime type of the page.

[chancancode]

@efx that’s probably the fix we can do in the medium term. I don’t know if chrome/firefox let you request that a content script to be injected only on html pages in the manifest. If they do, that’s great. If not, it’s not a big deal, we would just have to detect the document type in the content script and guard the script tag injection accordingly. If you or someone else is able to send a PR, it should be a fairly straightforward fix. Otherwise I’ll do it when I get back from vacation next week.