-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error message: routeHandler.get is not a function #1173
Comments
The relevant code for this is here ember-inspector/ember_debug/route-debug.js Line 166 in f1ab36a
@chancancode @pzuraq any reason why |
@siva-sundar are you using engines as well? |
@rwwagner90 Yes |
The issue is that the routes tab will try to list all the route instances. But we are getting this error while trying to list the routes of an engine which is not mounted. |
The possible solution would be to lazily list the routes of engine once its mounted. |
@siva-sundar I do not know anything about engines, but if you have a fix in mind, we would welcome a PR to make this work! There is a lot to do to support engines in general, and we would love help from someone who uses them and knows about them. |
Supporting engines would resolve this issue. #632
|
I don't know how to support engines. There was a spike by @cyril-sf at one point, but I don't think we ever got anything over the finish line. @chancancode I would be happy to pair with someone on engines support, I just have no idea how to make things work myself. |
@rwwagner90 Sorry for never finishing the feature. You can find my code (at least when I stopped) here : cyril-sf@ff5f266 |
Thanks @cyril-sf! @chancancode do we have an idea of what engines support should look like? If I have a goal in mind, perhaps I can build on the work Cyril did. |
Describe the bug
Getting the following error while switching to the Routes tab of the inspector. No data is being shown on the Routes tab due to this error.
To Reproduce
Steps to reproduce the behavior:
routeHandler.get is not a function
on the console.Screenshots
![image](https://user-images.githubusercontent.com/15258941/79546366-efdb9a00-80af-11ea-8882-10d620075327.png)
Environment
Ember version: 3.4.8
Browser: Chrome 80.0.3987.163
The text was updated successfully, but these errors were encountered: