Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component Tree - dissapears if modal-dialog used and focused using component explorer #1195

Closed
lifeart opened this issue May 8, 2020 · 3 comments
Closed

Component Tree - dissapears if modal-dialog used and focused using component explorer #1195

lifeart opened this issue May 8, 2020 · 3 comments
Labels
bug

Comments

@lifeart
Copy link
Contributor

lifeart commented May 8, 2020 •
edited
Loading

Issue is: part of component tree disappearing after focus on component.

  • all items outside ember-wormhole

image
image

Step 1:
image

Step 2:
select visuble part of component using component selection button (inside EmberModalDialogPositionedContainer)
image

image

Step 3:
See part of tree disappeared
image

Test:
http://31.184.253.199/
admin@admin.com / admin
and open http://31.184.253.199/groups/2/series/2/exercise/10/task/10
@lifeart lifeart added the bug label May 8, 2020
@lifeart
Copy link
Contributor Author

lifeart commented May 8, 2020

after "glitch" data tab remains broken
image

(no rows)

@lifeart
Copy link
Contributor Author

lifeart commented May 8, 2020

image

chancancode added a commit that referenced this issue May 9, 2020
@chancancode
Upgrade to 3.18
408c5f3 
There is a good chance this may fix issues like #1195. I haven't
dug in yet, but ember-source 3.17 has a bug with `{{#each}}` when
the same key is used more than once, which was fixed in 3.18.1 via
emberjs/ember.js#18941, but the fix was
never backported to 3.17 in time. So, we really should upgrade.
chancancode added a commit that referenced this issue May 9, 2020
@chancancode
Upgrade to 3.18
ed4beb9 
There is a good chance this may fix issues like #1195. I haven't
dug in yet, but ember-source 3.17 has a bug with `{{#each}}` when
the same key is used more than once, which is the kind of thing
that could easily break vertical collection and is at least
visually consistent with the errors reported by users. It was
fixed in 3.18.1 via emberjs/ember.js#18941
but the fix was never made it to 3.17 in time. So, either way, we
really should upgrade.
@chancancode chancancode mentioned this issue May 9, 2020
Merged
chancancode added a commit that referenced this issue May 9, 2020
@chancancode
Upgrade to 3.18
0b9e11f 
There is a good chance this may fix issues like #1195. I haven't
dug in yet, but ember-source 3.17 has a bug with `{{#each}}` when
the same key is used more than once, which is the kind of thing
that could easily break vertical collection and is at least
visually consistent with the errors reported by users. It was
fixed in 3.18.1 via emberjs/ember.js#18941
but the fix was never made it to 3.17 in time. So, either way, we
really should upgrade.
chancancode added a commit that referenced this issue May 9, 2020
@chancancode
Upgrade to 3.18 (#1196)
601c2cc 
There is a good chance this may fix issues like #1195. I haven't
dug in yet, but ember-source 3.17 has a bug with `{{#each}}` when
the same key is used more than once, which is the kind of thing
that could easily break vertical collection and is at least
visually consistent with the errors reported by users. It was
fixed in 3.18.1 via emberjs/ember.js#18941
but the fix was never made it to 3.17 in time. So, either way, we
really should upgrade.
@chancancode
Copy link
Member

According to @lifeart this is indeed fixed by #1196!

@chancancode chancancode mentioned this issue May 12, 2020
Closed
patricklx pushed a commit to patricklx/ember-inspector that referenced this issue Sep 19, 2022
@chancancode @patricklx
Upgrade to 3.18 (emberjs#1196)
acd171a 
There is a good chance this may fix issues like emberjs#1195. I haven't
dug in yet, but ember-source 3.17 has a bug with `{{#each}}` when
the same key is used more than once, which is the kind of thing
that could easily break vertical collection and is at least
visually consistent with the errors reported by users. It was
fixed in 3.18.1 via emberjs/ember.js#18941
but the fix was never made it to 3.17 in time. So, either way, we
really should upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chancancode @lifeart