Better keyboard navigation & devtools consistency

[kangax]

Is your feature request related to a problem? Please describe.

The recently added keyboard navigation in the components inspector is great but is often hard to work with because it doesn't follow the behavior of devtools that many developers are used to. Not only is it inconsistent but it also lacks functionality that makes it easy to navigate to the parent with one keypress in chunks of trees with many children.

Describe the solution you'd like

To mimic devtools behavior:

• in collapsed view right arrow should expand the element (this is implemented)
• in expanded view left arrow should collapse the element (this is implemented)
• in expanded view right arrow should jump to the first child
• in collapsed view left arrow should jump to the parent

Note that both Chrome and Firefox have the same behavior.

[nummi]

@kangax Thanks for the feedback. Would you be interested in submitting a PR for this?

[kangax]

@nummi I'd love to look into this but unsure I'll have much time in the near future. I'll post here if something changes.

[RobbieTheWagner]

@kangax happy to help if you have questions on this. Would love to get a PR going!

[geneukum]

Hey! I’d like to contribute to this project and this seems like a good first issue to tackle.

Does anyone mind if I assign this to myself?

[kangax]

Not a problem. Thanks for contributing!

…

On Mon, Apr 4, 2022 at 14:03 Geordan Neukum ***@***.***> wrote: Hey! I’d like to contribute to this project and this seems like a good first issue to tackle. Does anyone mind if I assign this to myself? — Reply to this email directly, view it on GitHub <#1537 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAC76VNDL2ESZ56RNWZTLVDMVFTANCNFSM4ZVVGHDQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[geneukum]

OK, I opened up a PR with a first cut at the changes here: #1959.

I'm definitely happy to make any modifications that are desirable to get this integrated. Thanks all!!

[RobbieTheWagner]

@geneukum since your PR is merged, should this be closed now?

[geneukum]

@rwwagner90, I think that this could be closed out, but it might be nice just to have @kangax sanity check the changes just to make sure that the updated keybindings work as expected?

[kangax]

@geneukum I can check but not sure if master was cut into a release yet?

[geneukum]

@kangax Ah, yeah, it doesn't look like it. I think that you'd need to build from source and then install that in order to be able to test these changes out.

I understand that's definitely a bit more involved though... We could always just close this issue out and then file a separate issue if there are any additional desired changes in the future.

[RobbieTheWagner]

Closing this issue for now. Will try to get a release out soon.