New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari Pop-Up #244
Comments
I'm also unable to use the ember inspector in safari 8 on yosemite, are you also on yosemite? |
It would be nice if we could get native Safari extension. |
I tried a bunch of options, but it will take some work, since Safari blocks IFRAME talk and their extension window API is terrible. I was trying to use the bookmarklet code and manipulate it to basically load in an injected div on the page if an Ember app was detected. But, I'll need to look at more options. One option is to embed the Ember Inspector app directly inside the extension. But that will require frequent updates. |
@tonycoco while not developed for this UC, you could also use the remote-inspector addon if you're working on an Ember CLI app. It works with websockets and allows the inspector to be openend in another window or even browser. |
Yeah, I've used that with success. Track the Safari/WebKit Web Inspector bug here I just created a new one - https://bugs.webkit.org/show_bug.cgi?id=140816 |
Looks like they're making progress on something for Safari on the Webkit Issue tracker. I'll try to update this thread with any information. |
Thanks @tonycoco! |
Any resolution on this, @teddyzeenny @tonycoco ? |
Not yet @locks. The WebKit bug was never resolved but there was talk of a developer extension API |
Where does this stand now? Does anyone use Ember Inspector in Safari with success? |
WebKit team hasn't started implementation of an API yet. No progress. |
I'm going to attempt to work on a native Safari extension. Apple does not make this easy at all. Does anyone have experience with Safari extension development? I've loosely been following http://frontendbabel.info/articles/developing-cross-browser-extensions/ and https://github.com/kritollm/chrome-extension-api-for-safari-and-firefox but both are pretty old. |
This is the branch I started https://github.com/emberjs/ember-inspector/tree/safari-extension |
Might be easier to take a firebug-style approach, where the inspector is
INSIDE the webpage. This could be a great starting point for making ember
more debug-able everywhere. This could hook into ember-cli somehow, or
perhaps you could just inject the script into the webpage via a safari
extension. Perhaps users could put the injected "ember-inspector.js" in
their vendor file, and the extension would attempt to inject
`location.origin + '/vendor/ember-inspector.js'
Come to think of it, probably better than putting a file into vendor, would
be to actually have an accompanying ember-addon, which defines a function,
`window.activateEmberInspector`, and then the safari extension simply has
to figure out a way to call it. Probably inject a script which just calls
it (literally just `window.activateEmberInspector()`)
(I don't have experience with native safari extensions, but
…On Fri, Sep 28, 2018 at 2:03 PM Robert Wagner ***@***.***> wrote:
This is the branch I started
https://github.com/emberjs/ember-inspector/tree/safari-extension
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#244 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAg8qJy55z-jELuRwKCjgf3CnTzegaO1ks5ufnKbgaJpZM4CvUxb>
.
|
Injecting a file would mean that mainstream usage does not get memory bloat
from defining the function. Then again, the function could be defined in
such a way that uses very very little memory. (Basically get the source
code as a string from somewhere _locally_ and eval it. Also saves parse
time for mainstream usage.)
…On Fri, Sep 28, 2018 at 2:14 PM devin rhode ***@***.***> wrote:
Might be easier to take a firebug-style approach, where the inspector is
INSIDE the webpage. This could be a great starting point for making ember
more debug-able everywhere. This could hook into ember-cli somehow, or
perhaps you could just inject the script into the webpage via a safari
extension. Perhaps users could put the injected "ember-inspector.js" in
their vendor file, and the extension would attempt to inject
`location.origin + '/vendor/ember-inspector.js'
Come to think of it, probably better than putting a file into vendor,
would be to actually have an accompanying ember-addon, which defines a
function, `window.activateEmberInspector`, and then the safari extension
simply has to figure out a way to call it. Probably inject a script which
just calls it (literally just `window.activateEmberInspector()`)
(I don't have experience with native safari extensions, but
On Fri, Sep 28, 2018 at 2:03 PM Robert Wagner ***@***.***>
wrote:
> This is the branch I started
> https://github.com/emberjs/ember-inspector/tree/safari-extension
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#244 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAg8qJy55z-jELuRwKCjgf3CnTzegaO1ks5ufnKbgaJpZM4CvUxb>
> .
>
|
At the moment, Safari lacks the necessary support for implementing Inspector there. We think the level of effort is not worth it at the moment, but may revisit in the future. |
what does it lack? are there some specific browser extension api's that are
missing? Why couldn't ember inspector be made to work firebug-style?
…On Fri, Nov 2, 2018 at 3:12 PM Robert Wagner ***@***.***> wrote:
Closed #244 <#244>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#244 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAg8qFAizu0sd07Rb0LSbIgQCAYndFoqks5urKcWgaJpZM4CvUxb>
.
|
@devinrhode2 if you have a specific Safari implementation in mind, you are welcome to take a stab at it, but Safari extensions are a huge mess. The current plan is to do like React and Vue are doing and make a standalone app for anything other than Chrome and Firefox. |
Safari blocks the pop-up for the bookmarklet... any fixes other than turning that feature off in the preferences?
The text was updated successfully, but these errors were encountered: