Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to point ember extension at a specific "iframe" #29

Closed
stefanpenner opened this issue Jul 26, 2013 · 18 comments
Closed

Ability to point ember extension at a specific "iframe" #29

stefanpenner opened this issue Jul 26, 2013 · 18 comments

Comments

@stefanpenner
Copy link
Member

low priority, but would be nice.

@teddyzeenny
Copy link
Contributor

Possible duplicate of #22 ?

@teddyzeenny
Copy link
Contributor

Implementing this will probably solve #22

@stefanpenner
Copy link
Member Author

similar yes, but likely different.

@wagenet
Copy link
Member

wagenet commented Aug 13, 2013

I think we'll want to be able to specify which frame, like in the console since you could in theory have multiple. Would be nice to find the first by default though.

@mansona
Copy link
Member

mansona commented Jan 30, 2014

We would very much like this feature, any thoughts on a milestone/timeline?

@ariroseonline
Copy link

+1 for iframe support. Besides JSBin and JSFiddle, we use Ember in our widget that's distributed to many sites. It would be lovely to be able to debug with the extension!

@stefanpenner
Copy link
Member Author

Ya, this would be awesome. We just need to find the bandwidth

@mansona
Copy link
Member

mansona commented Feb 16, 2014

@stefanpenner any chance someone could give a brief overview of how they would imagine it would work? i.e. how you would implement it given the time.

I'm just saying because maybe with that pointer someone might be able to put together a pull request. :)

@locks
Copy link
Contributor

locks commented Feb 17, 2014

FWIW I delved briefly into dealing with iframes but I have no idea :P
I wouldn't mind help push the ball once someone started rolling it.

@teddyzeenny
Copy link
Contributor

This is next on my list.

@stefanpenner
Copy link
Member Author

@teddyzeenny you are a machine.

@teddyzeenny
Copy link
Contributor

@stefanpenner I am no match for you :)

@lholmquist
Copy link

+1 for this

@teddyzeenny
Copy link
Contributor

I actually started working on that on the iframe branch. Currently only works on Google Chrome. When there are multiple iframes, you choose one from a dropdown.

I hit a Chrome issue with content scripts and blank iframes which prevented it from working with Jsbin.

So what is missing is making it work with blank iframes (such as Jsbin) and the Firefox version.

@ariroseonline
Copy link

@teddyzeenny thanks for the chrome inspector! Using it everyday for developing widgets that live on other sites inside iframes.

@robertleib
Copy link

@teddyzeenny I installed your iframe branch, but I am still getting the "Ember application not detected!" page in the tool, and I never see the drop-down. Any clues? Thanks!

@teddyzeenny
Copy link
Contributor

@robertleib I've fixed a few issues, try re-fetching iframes now. (Make sure you reload the extension after fetching).

There are several more issues, but it should be working on Chrome. I will complete this branch when I find some free time.

Let me know your feedback.

@teddyzeenny
Copy link
Contributor

PR: #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants