WIP: Support for multiple iframes #182
Conversation
|
👍 |
This commit introduces a complete refactoring/cleanup of the Firefox version, it supports Ember apps embedded into iframes on Firefox (Ember libraries detection and Devtool panel connection) and it has an optional tomster icon in the locationbar. The tomster icon can be enabled/disabled from the addon preferences, and it will be visible when an Ember app is detected in the tab or in an iframe inside the tab). Requirements: - Firefox >= 30.0 (needed for the "evalInWindow" method used in content-script) Tested on: - http://jsfiddle.net/9zHj9/1/ to be merged into emberjs#182
|
@teddyzeenny This is really awesome! I've just pushed the changes needed on Firefox firefox side and opened #187 to add more info about the changes. |
|
Wow :) Thank you @rpl for this amazing work!! Everything seems to be great except I can't run |
|
@teddyzeenny It's my pleasure. I just pushed as #189 a very small fix, which enables "file://" urls on the page-mod created by the Firefox addon. |
|
@rpl merged :) |
|
The Firefox tomster is now better than the Chrome one (detects iframes and has a button to open the inspector). |
This commit introduces a complete refactoring/cleanup of the Firefox version, it supports Ember apps embedded into iframes on Firefox (Ember libraries detection and Devtool panel connection) and it has an optional tomster icon in the locationbar. The tomster icon can be enabled/disabled from the addon preferences, and it will be visible when an Ember app is detected in the tab or in an iframe inside the tab). Requirements: - Firefox >= 30.0 (needed for the "evalInWindow" method used in content-script) Tested on: - http://jsfiddle.net/9zHj9/1/ to be merged into #182
Support for multiple iframes
|
wooooo! |
|
Hey guys, awesome work! I've been waiting for this one for ages 👍 Just have a question: i'm right in thinking this made it into the 1.4.0 verison of the chrome plugin right? I'm trying to get this to work on an iframe and I don't know how to point it at the frame |
|
Yes this is in 1.4.0. There should be a dropdown on the bottom left that lists the iframes that contain an Ember app.
|
|
So we don't get that far... does the frame need to be there on page load? We add the frame in after a button push and that might be the cause of this. Maybe i create an issue so we can discuss it there? |
|
This line is supposed to catch the new iframe. It might be related to the iframe URL or the iframe is sandboxed... Would be great if you can reproduce this online. |
Adds the ability to choose an iframe from a dropdown in case an Ember application was detected in more than one window / iframe.
I need some help with testing this in real life cases (only Chrome works currently).