Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember Inspector and Safari (OS X and iOS) #404

Closed
eccegordo opened this issue Jun 20, 2015 · 9 comments
Closed

Ember Inspector and Safari (OS X and iOS) #404

eccegordo opened this issue Jun 20, 2015 · 9 comments

Comments

@eccegordo
Copy link
Contributor

Has implementing this inspector for Safari been considered? Was it too much hassle or painful given Safari's extension architecture?

I still think Safari is an awesome browser and it looks like upcoming debugger tools in Safari are going to get a whole lot better, with some really cool new features. In particular their type profiling tool in their web inspector.

https://developer.apple.com/videos/wwdc/2015/?id=505

I would be interested in trying to take a stab at an implementation if only to learn ember inspector's internals better and make something viable for my favorite browser.

Anyway, just wondering if there is any advice I should heed before attempting this fool's errand?

Totally acceptable if the main answer is that the maintainers just don't have bandwidth to support another implementation. Just wanted know if there are any known technical hurdles I should be aware of?

Thanks.

@rwjblue
Copy link
Member

rwjblue commented Jun 20, 2015

The inspector works in safari already via bookmarklet (also works with IE this way). I'm not sure how much work a native extension would be though...

@teddyzeenny
Copy link
Contributor

We are happy to support Safari but AFAIK it's not possible to extend their devtools (unless something has changed since I last checked). As @rwjblue mentioned there's the bookmarklet option which already works with Safari. The bookmarklet though is not as powerful as the devtools version, so if there's a better way I'm all for it.

@eccegordo
Copy link
Contributor Author

I tried the bookmarklet but didn't seem to work. But maybe I did something wrong.

@teddyzeenny that was what I was wondering. So not extensible enough. Presumably you could build the inspector as a standalone extension but would require a lot of extra tooling to work.

I will have to do some more research. Thanks for the feedback.

My main mission is to better understand the internals.

@rwjblue
Copy link
Member

rwjblue commented Jun 21, 2015

This will likely sound silly, but I once thought the bookmarklet was broken with Sadari and it turned out I forgot to allow popups. Might be unrelated, but is worth checking...

@eccegordo
Copy link
Contributor Author

@rwjblue Whaddya know, that was it. That little check box buried deep down there I forget about it.

I can see the inspector now. But I think there a little flakiness. For example it opens up in a new tab, seems pretty easy to lose the inspector window.

@teddyzeenny
Copy link
Contributor

@eccegordo did you find another way (better than the bookmarklet)?

@eccegordo
Copy link
Contributor Author

Haven't found any way yet to extend devtools in safari. Feel free to close this issue. If I find anything useful I will report back.

@eccegordo
Copy link
Contributor Author

Actually taking the chrome dev tools out of the browser and making work with any browser seems like a good idea.

https://kenneth.io/blog/2014/12/28/taking-chrome-devtools-outside-the-browser/

Makes me wonder how viable it is to build stand alone ember inspector app? Could be handy with mobile debugging.

@teddyzeenny
Copy link
Contributor

The inspector is already an Ember app that you can launch standalone. Check out the remote inspector for mobile debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants