Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-jj-abrahams-resolver and ember-extension don't play nicely. #84

Closed
stefanpenner opened this issue Nov 12, 2013 · 0 comments
Closed

Comments

@stefanpenner
Copy link
Member

i did a thing in the new resolver that doesn't play nicely the with inspector:

I have the new resolver build a key based on the namespace + fullName. This looked strange without braces around it.
ember-cli/ember-resolver@79a3f7c

but it seems the regex extracting controllerName from subclasses merely checks for the existence of '('
https://github.com/tildeio/ember-extension/blob/master/ember_debug/view_debug.js#L490

Now, what I have done isn't final, and I am open to changes, but https://github.com/tildeio/ember-extension/blob/master/ember_debug/view_debug.js#L490 should likely be /^\(subclass of (.*)\).test(className) as match can return null.

teddyzeenny added a commit that referenced this issue Nov 12, 2013
[fixes #84] make extracting information from the toString method less brittle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant