We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i did a thing in the new resolver that doesn't play nicely the with inspector:
I have the new resolver build a key based on the namespace + fullName. This looked strange without braces around it. ember-cli/ember-resolver@79a3f7c
but it seems the regex extracting controllerName from subclasses merely checks for the existence of '(' https://github.com/tildeio/ember-extension/blob/master/ember_debug/view_debug.js#L490
Now, what I have done isn't final, and I am open to changes, but https://github.com/tildeio/ember-extension/blob/master/ember_debug/view_debug.js#L490 should likely be /^\(subclass of (.*)\).test(className) as match can return null.
/^\(subclass of (.*)\).test(className)
match
The text was updated successfully, but these errors were encountered:
f92c53e
Merge pull request #85 from stefanpenner/more-resiliant-match
2d67341
[fixes #84] make extracting information from the toString method less brittle
No branches or pull requests
i did a thing in the new resolver that doesn't play nicely the with inspector:
I have the new resolver build a key based on the namespace + fullName. This looked strange without braces around it.
ember-cli/ember-resolver@79a3f7c
but it seems the regex extracting controllerName from subclasses merely checks for the existence of '('
https://github.com/tildeio/ember-extension/blob/master/ember_debug/view_debug.js#L490
Now, what I have done isn't final, and I am open to changes, but https://github.com/tildeio/ember-extension/blob/master/ember_debug/view_debug.js#L490 should likely be
/^\(subclass of (.*)\).test(className)
asmatch
can return null.The text was updated successfully, but these errors were encountered: