Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember 3.12 #1008

Merged
merged 6 commits into from
Aug 19, 2019
Merged

Ember 3.12 #1008

merged 6 commits into from
Aug 19, 2019

Conversation

nummi
Copy link
Collaborator

@nummi nummi commented Aug 16, 2019 •
edited
Loading

  • Upgrade to 3.12
  • Run all the codemods

@nummi nummi changed the title WIP 3.12 3.12 Aug 16, 2019
RobbieTheWagner
RobbieTheWagner approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My only concern was if all the getters worked or if some might be proxies, but if there are edge cases, we will find them eventually 😃

@RobbieTheWagner RobbieTheWagner merged commit feca4bc into emberjs:master Aug 19, 2019
@RobbieTheWagner RobbieTheWagner changed the title 3.12 Ember 3.12 Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nummi @RobbieTheWagner