-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize Route Tab #1016
Modernize Route Tab #1016
Conversation
nummi
commented
Aug 28, 2019
- @
- this
- action
- on
- @ - this - action - on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions, but overall looking good!
|
||
export default Component.extend({ | ||
// passed as an attribute to the component | ||
currentRoute: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we no longer want these defaults to null
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed these because sooner or later this will become a Glimmer component and currentRoute
will live in the args
hash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to put it back for now.
id="options-hideRoutes" | ||
}} | ||
<Input | ||
@id="options-hideRoutes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be id
instead of @id
? Assuming id
is meant to be set on the element. Not sure if the input helper is a special case or not. Have you checked in the DOM to ensure the id is there and the input is working as expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just doing what the docs tell me :)
https://guides.emberjs.com/v3.12.0/templates/input-helpers/#toc_text-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I guess the input helper is a special case
id="options-hideSubstates" | ||
}} | ||
<Input | ||
@id="options-hideSubstates" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Hide Substates | ||
</label> | ||
</div> | ||
|
||
<div class="divider"></div> | ||
|
||
<div class="toolbar__search js-filter-views"> | ||
{{ui/toolbar-search-field value=searchValue}} | ||
{{ui/toolbar-search-field value=this.searchValue}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make this <Ui::Toolbar
etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to take another pass and convert all the Ui
components at one time.
* Remove unused component template * Modernize Route tab - @ - this - action - on