Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore dashes in search #1023

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Ignore dashes in search #1023

merged 2 commits into from
Sep 9, 2019

Conversation

nummi
Copy link
Collaborator

@nummi nummi commented Sep 8, 2019

@RobbieTheWagner
Copy link
Member

@nummi could we possibly add some quick tests for searching some terms with and without -?

@nummi
Copy link
Collaborator Author

nummi commented Sep 8, 2019 •
edited
Loading

@rwwagner90 Added some unit tests and updated a acceptance — is that good or would you like to see more acceptance tests?

@RobbieTheWagner
Copy link
Member

Added some unit tests — is that good or would you like to see an acceptance test?

These look good! Just trying to get some tests added whenever we change something, to ensure no regressions in the future 👍

@nummi nummi merged commit 5e1066d into emberjs:master Sep 9, 2019
@nummi nummi deleted the ignore-dashes-in-search branch September 9, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nummi @RobbieTheWagner