Tidy up data tab #1034
Merged
Tidy up data tab #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nummi
force-pushed
the
data-tab-cleanup
branch
from
67b2706
to
75ce722
Compare
nummi
commented
Sep 22, 2019
| @@ -1,8 +0,0 @@ | |||
| import { computed } from '@ember/object'; | |||
| import Component from '@ember/component'; | |||
| export default Component.extend({ | |||
There was a problem hiding this comment.
This component is replaced with a simple comparison in the template: https://github.com/emberjs/ember-inspector/pull/1034/files?file-filters%5B%5D=.hbs&hide-deleted-files=true#diff-97c2c032aa308abb534f8894b734348eR18
RobbieTheWagner
requested changes
Sep 22, 2019
app/helpers/is-empty.js
Outdated
| @@ -0,0 +1,8 @@ | |||
| import { isEmpty } from '@ember/utils'; | |||
There was a problem hiding this comment.
ember-truth-helpers already has an is-empty helper. Can we use that one instead?
app/controllers/records.js
Outdated
| return true; | ||
| filteredRecords: computed('searchValue', 'model.@each.{columnValues,filterValues}', 'filterValue', function() { | ||
| return this.model.filter((record) => { | ||
| return this.passesFilter(record) && this.passesSearch(record); |
There was a problem hiding this comment.
The logic for passesFilter and passesSearch seems fairly simple. Would you be okay with not pulling out into separate functions and leaving inside the computed?
nummi
force-pushed
the
data-tab-cleanup
branch
from
770ed63
to
88e1972
Compare
RobbieTheWagner
approved these changes
Sep 22, 2019
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* Add is-empty helper * explicit this for data tab * Remove record-filter component * Tidy up Records controller * Revert some changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.