Fix more items indicator sometimes not appearing #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
requested changes
Nov 17, 2019
| @@ -6,10 +6,10 @@ import { A } from '@ember/array'; | |||
| export default Component.extend({ | |||
| tagName: '', | |||
|
|
|||
| isArray: computed('properties', function () { | |||
There was a problem hiding this comment.
Should we leave this computed and switch it to 'properties.[] to ensure it updates?
There was a problem hiding this comment.
In this case I don't think it matters since it's only called once.
| if (this.get('isArray') && this.get('sorted.length') > 100) { | ||
| let props = A(this.get('sorted')); | ||
| if (this.isArray()) { | ||
| const item = props.findBy('name', 'length'); |
There was a problem hiding this comment.
This is to put the length property at the top, since otherwise it will be cutoff. Or it will look wierd at the end
|
@patricklx any updates here? Would like to get this in if it's still needed. |
|
@patricklx do we still need these changes? If so, could you please rebase? |
|
@patricklx do we still need this PR? |
|
Yes, it's still needed. It also makes sure that array items receive updates |
RobbieTheWagner
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, put the length property at the top