Adjust component tree colors #1109
Conversation
|
Having seen both, I think I actually like showing the @ sign as the same color as the identifier a lot more! IMO, just like instance variables in Ruby, the @ sign is essentially part of the variable name (since @foo and foo are talking about two different variables), the same color really helps drive that point home. |
|
@chancancode, @rwwagner90, can you take a look at the change I made here: https://github.com/emberjs/ember-inspector/pull/1109/files#diff-a9290a87bac9f17e7512cb19a835f822R12 ? It looks like the attr value coming out of Debug has double quotes around it — the result is the quotes being highlighted with the actual value. I felt it makes more sense for the quotes to be grey like the other less important syntax bits:
|
|
@nummi seems good to me |
| @@ -9,7 +9,7 @@ import { helper } from '@ember/component/helper'; | |||
| */ | |||
| export function componentArgumentDisplay([argument]) { | |||
| if (typeof argument === 'string') { | |||
| return JSON.stringify(argument); | |||
| return JSON.stringify(argument).replace(/^\"|\"$/g, ''); | |||
There was a problem hiding this comment.
At this point, this should probably just be argument.replace(/\"/g, '\\"');. Should probably leave a comment saying we are intentionally not wrapping it with quotes (doing it in the template), just escaping any interior quotes.
| return JSON.stringify(argument).replace(/^\"|\"$/g, ''); | |
| // Escape any interior quotes – we will add the surrounding quotes in the template | |
| return argument.replace(/\"/g, '\\"'); |
There was a problem hiding this comment.
I think this was a side effect of adding JSON.stringify. Before, the quotes were not part of the value.
| <span class="value-token"> | ||
| {{component-argument value}} | ||
| </span> | ||
| " | ||
| {{else}} | ||
| <span class="at-token"> |
There was a problem hiding this comment.
my personal opinion is that we probably don't need this 🤔
RobbieTheWagner
force-pushed
the
add-args
branch
from
0302acf
to
d26b64a
Compare
|
Closing in favor of #1112 |
@rwwagner90, here's a PR for your PR that is a PR for another PR.