-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Side docked inspector ergonimics #1121
Closed
betocantu93
wants to merge
12
commits into
emberjs:master
from
betocantu93:side-docked-inspector-ergonimics
Closed
Side docked inspector ergonimics #1121
betocantu93
wants to merge
12
commits into
emberjs:master
from
betocantu93:side-docked-inspector-ergonimics
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@betocantu93 we are working on some of the overflow issues as part of this PR #1112 Things have somewhat stalled with the holidays, but I will pick it back up soon. |
@rwwagner90 aight, let me know if anything, happy holidays |
@betocantu93 is everything sufficiently working for you now with overflows? |
Hey @rwwagner90 , yes I believe all of them are now solved, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and Steps to Reproduce
There are a few css improvements that can bump dev experience while using the inspector docked at right/left
Your environment
Chrome, Ember version 3.15, inspector >= 3.13
Screenshots
1. z-index for records lists / tables
2. the sidebar toggling button hides pretty easily
Not sure if this would be the best way to solve it, but since we ideally want the toggler "show/hide" always visible, I placed the button inside the object-inspector panel too, using absolute positioning.
Tests are missing, but first I wanted to get feedback, thanks