Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side docked inspector ergonimics #1121

Closed

Conversation

betocantu93
Copy link
Sponsor

@betocantu93 betocantu93 commented Dec 26, 2019

Issue and Steps to Reproduce

There are a few css improvements that can bump dev experience while using the inspector docked at right/left

  1. z-index for records lists / tables
  2. the sidebar toggling button hides pretty easily.

Your environment

Chrome, Ember version 3.15, inspector >= 3.13

Screenshots

1. z-index for records lists / tables

Screen Shot 2019-12-26 at 12 07 49 AM

2. the sidebar toggling button hides pretty easily

Screen Shot 2019-12-26 at 12 11 54 AM

Not sure if this would be the best way to solve it, but since we ideally want the toggler "show/hide" always visible, I placed the button inside the object-inspector panel too, using absolute positioning.

Tests are missing, but first I wanted to get feedback, thanks

@RobbieTheWagner
Copy link
Member

@betocantu93 we are working on some of the overflow issues as part of this PR #1112

Things have somewhat stalled with the holidays, but I will pick it back up soon.

@betocantu93
Copy link
Sponsor Author

@rwwagner90 aight, let me know if anything, happy holidays

@betocantu93 betocantu93 closed this Jun 1, 2020
@RobbieTheWagner
Copy link
Member

@betocantu93 is everything sufficiently working for you now with overflows?

@betocantu93
Copy link
Sponsor Author

Hey @rwwagner90 , yes I believe all of them are now solved, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants