fix component attrs inspect #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attrs is an object without prototype, so instanceof Object does not work but typeOf does
|
@chancancode @pzuraq does this look okay to you? |
|
@chancancode @pzuraq should we merge this? |
|
Sure, seems fine for now |
RobbieTheWagner
approved these changes
Apr 6, 2020
SYU15
pushed a commit
to SYU15/ember-inspector
that referenced
this pull request
Apr 25, 2020
attrs is an object without prototype, so instanceof Object does not work but typeOf does Co-authored-by: Robert Wagner <rwwagner90@gmail.com> Co-authored-by: Jerry Nummi <nummi@users.noreply.github.com>
patricklx
added a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
attrs is an object without prototype, so instanceof Object does not work but typeOf does Co-authored-by: Robert Wagner <rwwagner90@gmail.com> Co-authored-by: Jerry Nummi <nummi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attrs is an object without prototype, so instanceof Object does not work but typeOf does