-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
octane migration - deprecation-item-source #1906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor suggestions inline. Thanks for helping out :)
Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed tests were failing with map
being undefined. Left some suggestions. We may not need optional chaining everywhere, but I think we were missing args
at least.
all fixed now. |
Co-authored-by: Robert Wagner <rwwagner90@gmail.com>
* octane migration - deprecation-item-source * Update app/components/deprecation-item-source.js Co-authored-by: Ricardo Mendes <rokusu@gmail.com> * Update app/components/deprecation-item-source.js Co-authored-by: Ricardo Mendes <rokusu@gmail.com> * Update app/components/deprecation-item-source.js Co-authored-by: Ricardo Mendes <rokusu@gmail.com> * fix linting error * Update app/components/deprecation-item-source.hbs Co-authored-by: Robert Wagner <rwwagner90@gmail.com> Co-authored-by: Bing Dai <bdai@linkedin.com> Co-authored-by: Ricardo Mendes <rokusu@gmail.com> Co-authored-by: Robert Wagner <rwwagner90@gmail.com>
octane migration for deprecation-item-source
All tests passed.