Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octane migration - deprecation-item-source #1906

Merged
merged 6 commits into from
Feb 10, 2022

Conversation

michaelbdai
Copy link
Contributor

octane migration for deprecation-item-source

All tests passed.

locks
locks previously requested changes Feb 9, 2022
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions inline. Thanks for helping out :)

app/components/deprecation-item-source.js Outdated Show resolved Hide resolved
app/components/deprecation-item-source.js Outdated Show resolved Hide resolved
app/components/deprecation-item-source.js Show resolved Hide resolved
michaelbdai and others added 3 commits February 9, 2022 06:11
Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed tests were failing with map being undefined. Left some suggestions. We may not need optional chaining everywhere, but I think we were missing args at least.

app/components/deprecation-item-source.js Outdated Show resolved Hide resolved
app/components/deprecation-item-source.js Outdated Show resolved Hide resolved
app/components/deprecation-item-source.js Outdated Show resolved Hide resolved
app/components/deprecation-item-source.js Outdated Show resolved Hide resolved
@michaelbdai
Copy link
Contributor Author

Noticed tests were failing with map being undefined. Left some suggestions. We may not need optional chaining everywhere, but I think we were missing args at least.

all fixed now.

Co-authored-by: Robert Wagner <rwwagner90@gmail.com>
@RobbieTheWagner RobbieTheWagner merged commit d6f8610 into emberjs:master Feb 10, 2022
@michaelbdai michaelbdai deleted the bdai/dis branch February 10, 2022 20:53
patricklx pushed a commit to patricklx/ember-inspector that referenced this pull request Sep 19, 2022
* octane migration - deprecation-item-source

* Update app/components/deprecation-item-source.js

Co-authored-by: Ricardo Mendes <rokusu@gmail.com>

* Update app/components/deprecation-item-source.js

Co-authored-by: Ricardo Mendes <rokusu@gmail.com>

* Update app/components/deprecation-item-source.js

Co-authored-by: Ricardo Mendes <rokusu@gmail.com>

* fix linting error

* Update app/components/deprecation-item-source.hbs

Co-authored-by: Robert Wagner <rwwagner90@gmail.com>

Co-authored-by: Bing Dai <bdai@linkedin.com>
Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
Co-authored-by: Robert Wagner <rwwagner90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants