Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecations: fix instances of routing-transition-methods #1974

Merged
merged 1 commit into from
Apr 24, 2022
Merged

deprecations: fix instances of routing-transition-methods #1974

merged 1 commit into from
Apr 24, 2022

Conversation

geneukum
Copy link
Contributor

@geneukum geneukum commented Apr 23, 2022

Description

The methods transitionTo and replaceWith of the Route have been
deprecated in order to reduce the API surface related to routing.
Instead, we should inject the Router Service and use its transitionTo()
method.

Screenshots

n/a

The methods transitionTo and replaceWith of the Route have been
deprecated in order to reduce the API surface related to routing.
Instead, we should inject the Router Service and use its transitionTo()
method.
@RobbieTheWagner RobbieTheWagner merged commit 3a0fab3 into emberjs:master Apr 24, 2022
@geneukum geneukum deleted the fixup-routing-transition-methods-deprecations branch April 24, 2022 13:38
patricklx pushed a commit to patricklx/ember-inspector that referenced this pull request Sep 19, 2022
The methods transitionTo and replaceWith of the Route have been
deprecated in order to reduce the API surface related to routing.
Instead, we should inject the Router Service and use its transitionTo()
method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants