deprecations: fixup instances of no-inline-styles #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ember-template-lint's no-inline-styles rule forbids using inline styles as they are often harder to maintain and can make the overall size of the project bigger. It recommends using css classes instead. Let's fixup any instances of this issue in the codebase and then re-enable the rule in our template-lintrc so that the linter will help us avoid adding more instances of this in the future.
RobbieTheWagner
approved these changes
Apr 25, 2022
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
ember-template-lint's no-inline-styles rule forbids using inline styles as they are often harder to maintain and can make the overall size of the project bigger. It recommends using css classes instead. Let's fixup any instances of this issue in the codebase and then re-enable the rule in our template-lintrc so that the linter will help us avoid adding more instances of this in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ember-template-lint's no-inline-styles rule forbids using inline styles
as they are often harder to maintain and can make the overall size of
the project bigger. It recommends using css classes instead.
Let's fixup any instances of this issue in the codebase and then
re-enable the rule in our template-lintrc so that the linter will help
us avoid adding more instances of this in the future.
Screenshots
n/a