render-item: fixup no-curly-component-invocation #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two ways to invoke a component in a template: curly component
syntax ({{my-component}}), and angle bracket syntax (<MyComponent />).
The difference between them is syntactical. We should favour angle
bracket syntax as it improves readability of templates, i.e.
disambiguates components from helpers, and is also the future direction
Ember is going with the Octane Edition.
As such, let's fix up the render-item template so that it follows this
syntax and then remove the manual disabling of this linting rule so that
the linter will warn us against adding more issues of this type in the
future.
RobbieTheWagner
approved these changes
Apr 27, 2022
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
There are two ways to invoke a component in a template: curly component
syntax ({{my-component}}), and angle bracket syntax (<MyComponent />).
The difference between them is syntactical. We should favour angle
bracket syntax as it improves readability of templates, i.e.
disambiguates components from helpers, and is also the future direction
Ember is going with the Octane Edition.
As such, let's fix up the render-item template so that it follows this
syntax and then remove the manual disabling of this linting rule so that
the linter will warn us against adding more issues of this type in the
future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are two ways to invoke a component in a template: curly component
syntax ({{my-component}}), and angle bracket syntax ().
The difference between them is syntactical. We should favour angle
bracket syntax as it improves readability of templates, i.e.
disambiguates components from helpers, and is also the future direction
Ember is going with the Octane Edition.
As such, let's fix up the render-item template so that it follows this
syntax and then remove the manual disabling of this linting rule so that
the linter will warn us against adding more issues of this type in the
future.
Screenshots
n/a