object-inspector-test: fix legacy-attribute-arguments issue #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, when we run the 'Views are correctly handled when destroyed
during transitions' test from the 'Ember Debug - Object Inspector'
suite, there is a deprecation logged along the lines of:
Passing the `@class` argument to <Input> is deprecated. Instead,
please pass the attribute directly, i.e. `<Input class={{...}} />`
instead of `<Input @Class={{...}} />` or `{{input class=...}}`.
Let's fix this deprecation by preferring angle bracket syntax for the
input component. This will help avoid having an unnecessary deprecation
show up in the test output.
RobbieTheWagner
approved these changes
Apr 28, 2022
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
…1991) Right now, when we run the 'Views are correctly handled when destroyed during transitions' test from the 'Ember Debug - Object Inspector' suite, there is a deprecation logged along the lines of: Passing the `@class` argument to <Input> is deprecated. Instead, please pass the attribute directly, i.e. `<Input class={{...}} />` instead of `<Input @Class={{...}} />` or `{{input class=...}}`. Let's fix this deprecation by preferring angle bracket syntax for the input component. This will help avoid having an unnecessary deprecation show up in the test output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, when we run the 'Views are correctly handled when destroyed
during transitions' test from the 'Ember Debug - Object Inspector'
suite, there is a deprecation logged along the lines of:
Let's fix this deprecation by preferring angle bracket syntax for the
input component. This will help avoid having an unnecessary deprecation
show up in the test output.
Screenshots
n/a