fix component tree item show #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parent should be parentItem this is called e.g when inspecting components via the toggle button in the components route or when clicking inspect component in the context menu
|
@patricklx thanks for the PR! Would it be possible to add some tests? I find it odd that this was incorrect and nothing caught it. |
RobbieTheWagner
approved these changes
Jun 22, 2022
|
Thanks for the PR @patricklx! |
patricklx
added a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* fix component tree item show parent should be parentItem this is called e.g when inspecting components via the toggle button in the components route or when clicking inspect component in the context menu * add test for auto expanding to pinned item * Update component-tree-test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent should be parentItem
this is called e.g when inspecting components via the toggle button in the components route or when clicking inspect component in the context menu. it then expands to the selected item in the component view