bring back tracked dependencies #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
force-pushed
the
bring_back_tracked_deps
branch
9 times, most recently
from
3082830
to
cc30d49
Compare
|
@patricklx Thanks for the PR! Could we add some tests around this? It seems rather complex and I want to make sure we don't have regressions. |
patricklx
force-pushed
the
bring_back_tracked_deps
branch
5 times, most recently
from
26af60b
to
14bc4aa
Compare
patricklx
force-pushed
the
bring_back_tracked_deps
branch
from
14bc4aa
to
1774755
Compare
RobbieTheWagner
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in earlier versions of ember, tags had an _propertyKey which was used to show some tracked dependencies of getters. this brings it back for current versions.
in addition I tried to improve the way its displayed
Screenshots