-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix manifest #2476
fix manifest #2476
Conversation
@patricklx was |
i'm not sure 😅 |
IIRC things worked locally for me, even with manifest v3. You were seeing an error? Does this resolve that error? |
yes, it loads the extension now, but it fails to load on any page... |
I understand now. adding inline scripts directly is not allowed any more. But its possible to load scripts that are specified in the allowed resourced inside the manifest. |
@@ -90,7 +90,7 @@ | |||
if (!injected) { | |||
// cannot use eval here, as the context is limited to the content script- | |||
const elem = document.createElement('script') ; | |||
elem.textContent = message.value; | |||
elem.src = chrome.runtime.getURL('panes-3-16-0/ember_debug.js'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will specifically loading 3-16-0 here break our check where we switch to different versions for older Ember?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just testing now. I will change it later
I think thizis ready. |
0b34c6b
to
3c49cfe
Compare
Squashed and ready |
7d90cd5
to
d41b662
Compare
this might also fix #1158 |
@patricklx have you checked to make sure the older versions still boot up for Ember < 3.16? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thank you so much for your help 🎉. I just want to make sure we test these changes against some older Ember versions, to make sure loading the old versions works still.
finally found a website... |
fixes #1158