Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve route debug #2536

Merged
merged 1 commit into from
Feb 12, 2024
Merged

improve route debug #2536

merged 1 commit into from
Feb 12, 2024

Conversation

patricklx
Copy link
Collaborator

@patricklx patricklx commented Dec 27, 2023 •
edited
Loading

  • use backburner instead of setInterval
  • use routeHandler.get
  • show error if getting routes failed

@patricklx patricklx force-pushed the improve-route-debug branch 2 times, most recently from 173e6db to 1537272 Compare December 27, 2023 12:58
RobbieTheWagner
RobbieTheWagner approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me 👍

@RobbieTheWagner RobbieTheWagner merged commit f93c70b into emberjs:main Feb 12, 2024
15 checks passed
@patricklx patricklx deleted the improve-route-debug branch February 12, 2024 14:40
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patricklx @RobbieTheWagner