Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix render tree triggering when already destroyed #2547

Merged
merged 2 commits into from
Feb 4, 2024
Merged

fix render tree triggering when already destroyed #2547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4686ca8
fix render tree triggering when already destroyed
patricklx Feb 1, 2024
e763049
fix isDestroying
patricklx Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ember_debug/utils/base-object.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ export default class BaseObject {
}

init() {}
willDestroy() {}
willDestroy() {
this.isDestroying = true;
}

destroy() {
this.willDestroy();
Expand Down
2 changes: 1 addition & 1 deletion ember_debug/view-debug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export default class extends DebugPort {
}

send() {
if (this.isDestroying) {
if (this.isDestroying || this.isDestroyed) {
return;
}

Expand Down
Loading