Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add request permissions page #2569

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

patricklx
Copy link
Collaborator

@patricklx patricklx commented Apr 29, 2024

fixes #2516

Description

this adds a link to a request permission page for ember inspector.
It can only be requested during an user action, like a click.
The page will open in a separate window, this is one of the possibilities to request permissions.
It cannot be done directly from the extension page in devtools.

Screenshots

image

@patricklx patricklx force-pushed the request-permissions branch 7 times, most recently from 62ea45c to 0f02cd1 Compare April 29, 2024 10:37
@RobbieTheWagner
Copy link
Member

@patricklx can you please explain in more detail what this PR is for? Is it just a shortcut to request permissions? Can we not add the request permissions stuff to the icon in the toolbar of Chrome?

@patricklx
Copy link
Collaborator Author

@RobbieTheWagner in the toolbar you can already click on the ember icon and select which permissions to give to local website. So this is just a shortcut and a link to the page will be presented on the ember inspector error page.

@patricklx patricklx requested review from RobbieTheWagner and removed request for RobbieTheWagner June 24, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ember application not detected with Firefox 120.0
2 participants