- Refactor tests/ & app/ folders to use let & const and destructuring… #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| var computed = Ember.computed; | ||
|
|
||
| var WebsocketAdapter = BasicAdapter.extend({ | ||
| let WebsocketAdapter = BasicAdapter.extend({ |
There was a problem hiding this comment.
We should just export default BasicAdapter.extend
|
@Mawaheb looks great!! Left a few minor comments. |
|
@teddyzeenny Thanks for the feedback, I will make the changes and push again :) |
… to import Ember classes. - Add bable. - WIP, using let & const and destructuring to import Ember classes. - Complete refactoring app/ to use let & cost and destructuring. - Minor edits.
Mawaheb
force-pushed
the
operationCleanUpRefactor
branch
from
05a1626
to
c6d866a
Compare
|
Done!, Please let me know if you have any notes. |
|
Nice! |
teddyzeenny
added a commit
that referenced
this pull request
May 23, 2015
- Refactor tests/ & app/ folders to use let & const and destructuring…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step of WIP that covers #360
In this PR, the contents of App/ and Test/ folders are refactored to use ES6's
let&constand use destructuring to import Ember classes.