Change the build process to build all targets at once #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddyzeenny
force-pushed
the
new-build-setup
branch
2 times, most recently
from
ccf41f0
to
2f6e208
Compare
Previously each build could target only one output at a time. You would need to decide what you're targeting before calling the build/serve commands. We also had to use environment variables to set the type of dist. For example, to build for Chrome, you would need to do: `EMBER_DIST=chrome ember build --output-path dist_chrome/panes` The build output would end up in `dist_chrome`. The Firefox targetted build would end up in `dist_firefox`.. etc. This commit changes the entire concept from one build per target to one build that targets everything. We now only need to call: `ember build` to build all the outputs inside the `dist` directory. The `dist` directory will contain `chrome`, `firefox`, `websocket`, `bookmarklet` directories. Build time takes almost the same time to build all outputs because the difference between them is very minor.
teddyzeenny
added a commit
that referenced
this pull request
Jun 3, 2015
Change the build process to build all targets at once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously each build could target only one output at a time. You would need to decide what you're targeting before calling the build/serve commands. We also had to use environment variables to set
the type of dist.
For example, to build for Chrome, you would need to do:
EMBER_DIST=chrome ember build --output-path dist_chrome/panesThe build output would end up in
dist_chrome. The Firefox targetted build would end up indist_firefox.. etc.This commit changes the entire concept from one build per target to one build that targets everything. We now only need to call:
ember buildto build all the outputs inside the
distdirectory. Thedistdirectory will containchrome,firefox,websocket,bookmarkletdirectories. Build time takes almost the same time to build all outputs because the difference between them is very minor.This is possible thanks to @joliss who started the work on this and has been advising me throughout my work on this.