Update Firefox skeleton for path change in Firefox 44 and later #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddyzeenny
added a commit
that referenced
this pull request
Sep 22, 2015
Update Firefox skeleton for path change in Firefox 44 and later
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Firefox 44, we are moving DevTools files to a new location. This impacts some add-ons that import those files at their old paths.
For Ember, there's only two imports to clean up.
I've updated the add-on to use the new path when available (Firefox 44 and later) and fallback to the old one if not.
I tested this add-on build in Firefox 43 and 44.
At the moment, the old path also works in 44, but we'll soon start logging deprecation warnings for the old paths, so now you'll already be updated to avoid such warnings.