Skip in page script injection in Chrome PDF Viewer #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an issue in all current Chrome versions, where the built-in PDF-Viewer only displays a blank page, if the Ember Inspector extension is active. This fix works around the issue, by skipping the injection if the document's content type is reported as PDF.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue in all current Chrome versions, where the built-in PDF-Viewer only displays a blank page, if the Ember Inspector extension is active.
This fix works around the issue, by skipping the injection if the document's content type is reported as PDF which should never be true for normal HTML pages.
Fixes #532.
For a test case see issue #532.