Sort model properties #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing due to my time constraints. There is a bit more work, as a few tests are failing, but this is the general idea on how to sort properties. |
|
@locks Any reason for the re-open? It'd be awesome if you could tackle this ;) |
|
@ryanlitalien just tried it locally and it doesn't seem to be failing tests anymore. You should try re-running the CI build. (I think closing/re-opening the PR triggers that?) |
locks
approved these changes
Oct 16, 2017
|
@teddyzeenny Can you please merge and release? Thanks! |
teddyzeenny
suggested changes
Oct 19, 2017
app/components/mixin-detail.js
Outdated
| @@ -17,6 +17,9 @@ export default Component.extend({ | |||
| return this.get('model.expand') && this.get('model.properties.length') > 0; | |||
| }), | |||
|
|
|||
| sortProperties: ['name'], | |||
| sortedProperties: sort('model.properties', 'sortProperties'), | |||
There was a problem hiding this comment.
Can you please document these? We're trying to document new code to slowly transition to a documented codebase.
/**
* Used by the `sort` computed macro.
*
* @property sortProperties
* @type {Array<String>}
*/
sortProperties: ['name'],
/**
* Sort the properties by name to make them easier to find in the object inspector.
*
* @property sortedProperties
* @type {Array<Object>}
*/
sortedProperties: sort('model.properties', 'sortProperties'),
teddyzeenny
approved these changes
Oct 21, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort the properties of the selected mixin on the object-inspector sidebar.
Mentioned in this issue: #562
(I had some issues with tests, though running it against my Ember app, the properties were sorted correctly)