[WIP] Firefox WebExtension #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2017
Closed
teddyzeenny
added a commit
that referenced
this pull request
Sep 9, 2017
Update the old snapshot (for Ember < 2.7) to the new FF WebExtension API. Part of #715
locks
reviewed
Sep 10, 2017
app/adapters/chrome.js
Outdated
| @@ -1,5 +1,21 @@ | |||
| import WebExtension from "./web-extension"; | |||
|
|
|||
| export default WebExtension.extend({ | |||
| name: 'chome' | |||
| name: 'chome', | |||
- Added meta charset utf-8 tag to html pages - Set the devtools icon to base off the PANE_ROOT - Updated WebExtension APIs to use chrome.runtime from chrome.extension
teddyzeenny
force-pushed
the
firefox-webextension
branch
from
abef11f
to
21b91dc
Compare
|
Woohoo thanks everyone for the awesome work! 💯 🎉 ❤️ |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work started by @clarkbw in #667. cc @rpl
Remaining things:
chrome.devtools.inspectedWindow.onResourceAddedbut FF doesn't support it at the moment). [REMOVED SUPPORT IN FF].