Refactor duplication #792
Merged
Refactor duplication #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddyzeenny
approved these changes
Apr 29, 2018
ember_debug/mixins/port-mixin.js
Outdated
| removePortListeners() { | ||
| /** | ||
| * Setup or tear down port listeners. Call on `init` and `willDestroy` | ||
| * @param onOrOff 'on' or 'off' the functions to call i.e. port.on or port.off for adding or removing listeners |
There was a problem hiding this comment.
@param {String} onOrOff
app/controllers/component-tree.js
Outdated
| expandAll() { | ||
| /** | ||
| * Expand or collapse all component nodes | ||
| * @param {boolean} expanded If true, expanded, if false, collapsed |
There was a problem hiding this comment.
Is that a standard to capitalize the types?
teddyzeenny
pushed a commit
that referenced
this pull request
May 25, 2018
cyril-sf
pushed a commit
to cyril-sf/ember-inspector
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some light refactoring to remove a bit of duplication