New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context menu item for inspecting components #843
Conversation
Relying on the `emberVersion` message as the trigger point for setting the context menu isn't always reliable.
0932d0c
to
7ee982c
Compare
This PR pretty much adds an extra commit or two onto the work that @thorsteinsson already did, so the credit is firmly his. |
When an item is inspected via the context menu we try to put it into view in the component tree. We make an educated guess as to how far down we should scroll based on the item's index and a magic height number
7ee982c
to
c574c94
Compare
Nice work @thorsteinsson and @Bestra! I hate to ask, but any chance we could get some test coverage for this feature? 😄 |
@rwwagner90 😅 I can probably write an acceptance test that takes an incoming message from the port and highlights a given item. I think that'll cover the happy path for the real thing. Off I go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems great to me! 🎉
Great work @Bestra! I'm so happy to see this land. |
* Context menu item for "Inspect Ember Component" * Try to set context menu when inspector loads Relying on the `emberVersion` message as the trigger point for setting the context menu isn't always reliable. * Scroll component tree to selected item When an item is inspected via the context menu we try to put it into view in the component tree. We make an educated guess as to how far down we should scroll based on the item's index and a magic height number * Add specs for inspecting item via context menu
Features:
This PR supersedes WIP: Context menu item for "Inspect Ember Component" #788. Closes Implement "Inspect component" contextual menu #689