Add hooks API for setupContainerTest() to improve beforeEach/afterEach ordering #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Feb 21, 2018
| beforeEachHooks.push(fn); | ||
| }, | ||
| afterEach(fn) { | ||
| afterEachHooks.push(fn); |
There was a problem hiding this comment.
should we use unshift() instead so that we don't have to .reverse()?
| function setupFoo(hooks) { | ||
| hooks.beforeEach(function() { | ||
| expect(this.owner, 'Context is set up already').to.exist; | ||
| this.count = 0; |
There was a problem hiding this comment.
- due to the context resetting stuff we do we should probably track this outside of
this - I think it would be better to track the order with a step list instead of incrementing a counter
simonihmig
force-pushed
the
hooks-workaround
branch
from
ca5178c
to
af3e754
Compare
simonihmig
force-pushed
the
hooks-workaround
branch
from
af3e754
to
5f48e0f
Compare
Turbo87
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #190 (comment)