Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure start call is documented in README #375

Merged
merged 1 commit into from May 15, 2019

Conversation

maxfierke
Copy link
Contributor

Ensure that the tests/test-helper.js example in README also shows the call to start. Otherwise, the tests will hang :(

Ensures that the `tests/test-helper.js` example in README also shows the call to `start`. Otherwise, the tests will hang :(
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, totally missed that, sorry 😞

@Turbo87 Turbo87 merged commit d175c20 into emberjs:master May 15, 2019
@maxfierke maxfierke deleted the mf-docs_mocha_start branch May 15, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants