Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing in beforeEach() due to module being undefined #268

Closed
bendemboski opened this issue Apr 12, 2017 · 3 comments
Closed

Tests failing in beforeEach() due to module being undefined #268

bendemboski opened this issue Apr 12, 2017 · 3 comments
Labels

Comments

@bendemboski
Copy link

I'm seeing a bizarre error that appears to be caused by #260. I run my whole suite, and a few modules towards the end of the suite fail because module is undefined in beforeEach. I put in some logging, and before is not being called for these module. I can see beforeEach() being called for each test (with module=undefined), and after being called, but before is not getting called.

The tests that are failing are my route and service unit tests -- a couple of route tests pass, then the rest and all the service tests fail, then next is some non-ember-qunit modules that pass.

ember-cli@2.9.1
ember-cli-qunit@3.1.2
ember-qunit@2.1.2
qunitjs@2.3.1
me@super.duper.confused
@bendemboski
Copy link
Author

Turns out this is a bug in QUnit triggered when the first or last test in a module is skipped. I opened a PR with a fix over there.

@trentmwillis
Copy link
Member

Labelling as a bug and leaving this open even though the fix will be upstream.

@trentmwillis
Copy link
Member

Fix has been merged upstream, will be out in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants