Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract test app #1062

Merged
merged 5 commits into from Jun 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Expand Up @@ -23,7 +23,7 @@ jobs:
- uses: wyvox/action@v1
- run: pnpm lint
- run: pnpm test:ember
working-directory: addon
working-directory: test-app

floating-dependencies:
name: 'Floating Dependencies'
Expand All @@ -35,7 +35,7 @@ jobs:
with:
pnpm-args: '--no-lockfile'
- run: pnpm test:ember
working-directory: addon
working-directory: test-app

try-scenarios:
name: 'Try: ${{ matrix.ember-try-scenario }}'
Expand All @@ -60,7 +60,7 @@ jobs:
- uses: wyvox/action@v1
- name: test
run: node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup
working-directory: addon
working-directory: test-app

types:
runs-on: ubuntu-latest
Expand Down
6 changes: 3 additions & 3 deletions addon/CONTRIBUTING.md
Expand Up @@ -4,12 +4,12 @@

* `git clone <repository-url>`
* `cd ember-qunit`
* `yarn install`
* `pnpm install`

## Linting

* `yarn lint`
* `yarn lint:fix`
* `pnpm lint`
* `pnpm lint:fix`

## Running tests

Expand Down
2 changes: 1 addition & 1 deletion addon/RELEASE.md
Expand Up @@ -31,7 +31,7 @@ Once the prep work is completed, the actual release is straight forward:
* First, ensure that you have installed your projects dependencies:

```sh
yarn install
pnpm install
```

* Second, ensure that you have obtained a
Expand Down
7 changes: 3 additions & 4 deletions addon/package.json
Expand Up @@ -51,7 +51,7 @@
"@ember/optional-features": "^2.0.0",
"@ember/string": "^3.1.1",
"@ember/test-helpers": "^3.0.3",
"@embroider/test-setup": "^2.1.1",
"@embroider/test-setup": "^3.0.1",
"@glimmer/component": "^1.1.2",
"@tsconfig/ember": "^2.0.0",
"@types/qunit": "^2.19.4",
Expand All @@ -76,7 +76,7 @@
"expect-type": "^0.15.0",
"loader.js": "^4.7.0",
"npm-run-all": "^4.1.5",
"prettier": "2.8.4",
"prettier": "2.8.8",
"qunit": "^2.19.4",
"release-it": "^15.7.0",
"release-it-lerna-changelog": "^5.0.0",
Expand Down Expand Up @@ -126,7 +126,6 @@
}
},
"volta": {
"node": "18.16.0",
"yarn": "1.22.19"
"extends": "../package.json"
}
}
21 changes: 0 additions & 21 deletions addon/tests/dummy/config/ember-cli-update.json

This file was deleted.

15 changes: 0 additions & 15 deletions addon/tests/dummy/public/crossdomain.xml

This file was deleted.

5 changes: 0 additions & 5 deletions addon/tests/helpers/destroy-app.js

This file was deleted.

26 changes: 0 additions & 26 deletions addon/tests/helpers/module-for-acceptance.js

This file was deleted.

18 changes: 0 additions & 18 deletions addon/tests/helpers/resolver.js

This file was deleted.

15 changes: 0 additions & 15 deletions addon/tests/helpers/start-app.js

This file was deleted.

5 changes: 0 additions & 5 deletions addon/tests/integration/setup-test-test.js
Expand Up @@ -2,13 +2,8 @@ import { module, test } from 'qunit';
import Service, { inject as injectService } from '@ember/service';
import Component from '@ember/component';
import { setupTest } from 'ember-qunit';
import { setResolverRegistry } from '../helpers/resolver';

module('setupTest tests', function (hooks) {
hooks.beforeEach(function () {
setResolverRegistry({});
});

setupTest(hooks);

test('can be used for unit style testing', function (assert) {
Expand Down
6 changes: 0 additions & 6 deletions addon/tests/test-helper.js

This file was deleted.