Bring back disableContainerStyles #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
NullVoxPopuli
force-pushed
the
bring-back-disableContainerStyles
branch
from
0829d06
to
a8b8509
Compare
NullVoxPopuli
commented
Aug 9, 2023
| * | ||
| * removes the CSS for the test-container (where the app and components are rendered to) | ||
| */ | ||
| disableContainerStyles: true, |
There was a problem hiding this comment.
This was previously an undocumented feature
NullVoxPopuli
commented
Aug 9, 2023
| return window.getComputedStyle(element); | ||
| } | ||
|
|
||
| test('the styles are present', async function (assert) { |
There was a problem hiding this comment.
These are how I test that the styles are included
NullVoxPopuli
commented
Aug 9, 2023
| return window.getComputedStyle(element); | ||
| } | ||
|
|
||
| test('the styles are not present', async function (assert) { |
There was a problem hiding this comment.
These are how I test that the styles are not included
wagenet
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves: #1100
Blocked by: ember-cli/ember-cli#10296 (locally, I symlinked to this branch)This this PR is 99% boilerplate (new app), you'll want to review by-commit.
The new app is added in one commit, and all the other commits are actually meaningful.
ember-cli-build.js'sember-qunit#disableContainerStyleswas previously undocumented, but in the interest of keeping the behavior for the upcoming v8 release, this PR re-implements the functionality that was temporarily lost in the v2-addon conversion (because v2 addons don't / can't modify the build).This approach uses
@embroider/macrosfor statically analyzable config (note that@embroider/macroscan be used in non-embroider apps).Additionally, this behavior is now documented in the README with instructions for setup.
Additionally additionally, I switched the way the test-apps reference ember-qunit to use
dependenciesMeta.*.injected, which treats the files fromember-qunitas they would exist as installed fromnpm-- this gives us the highest confidence that how we test is how users ofember-qunitwill experience the library.In order to test this behavior, I added another test-app, which only has one test -- asserting that the container styles are defaults (and different from what our container CSS does)