Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit service injection fails in unit tests for dasherized names #108

Closed
elwayman02 opened this issue Oct 8, 2015 · 3 comments · Fixed by #113
Closed

Implicit service injection fails in unit tests for dasherized names #108

elwayman02 opened this issue Oct 8, 2015 · 3 comments · Fixed by #113

Comments

@elwayman02
Copy link
Contributor

Given a service foo-bar, a route with fooBar: Ember.inject.service(), and a unit test with needs: ['service:foo-bar'], the test blows up and fails to find the injected service via implicit name lookup.

@elwayman02
Copy link
Contributor Author

If you explicitly inject, it works...ie fooBar: Ember.inject.service('foo-bar')

@rwjblue
Copy link
Member

rwjblue commented Oct 16, 2015

Based on https://github.com/rwjblue/ember-qunit/issues/199, I think this may be related to resolver shenanigans (and not directly related to services themselves).

@rwjblue
Copy link
Member

rwjblue commented Oct 20, 2015

I've got a solution that I am working on for this, hopefully will have a PR ready shortly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants