Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on klassy, prefer raw JS or core-object #56

Closed
stefanpenner opened this issue Jun 2, 2015 · 11 comments
Closed

remove dependency on klassy, prefer raw JS or core-object #56

stefanpenner opened this issue Jun 2, 2015 · 11 comments

Comments

@stefanpenner
Copy link
Member

cc @dgeb

@rwjblue
Copy link
Member

rwjblue commented Jun 2, 2015

Why?

@stefanpenner
Copy link
Member Author

why not?

@stefanpenner
Copy link
Member Author

It's another dep, that does the same thing as other stuff we already have. Seems strange to add yet another object model.

Ultimately, if it was published to NPM it would be more reasonable.

@rwjblue
Copy link
Member

rwjblue commented Jun 2, 2015

why not?

Because we have something that works here, and a bunch of other things that are actually broken we could put our times into...

@dgeb
Copy link
Member

dgeb commented Jun 9, 2015

One of the reasons I wrote klassy.js was to have an object model in which classes could take constructor arguments. This capability is used to good effect in ember-test-helpers.

I'd be glad to publish to npm. Do either of you publish ES6-module-only libs to npm (i.e. without transpiled builds)? Looking for some conventions to follow...

@dgeb
Copy link
Member

dgeb commented Jun 9, 2015

Alright - I've published klassy to npm: https://www.npmjs.com/package/klassy

This is something I've meant to do anyway, so thanks for the push.

Sooo... ember-test-helpers itself is only published to bower, and it's published without a build step, and klassy is currently a bower dependency. What is the ideal configuration you're looking for here?

@stefanpenner
Copy link
Member Author

Sooo... ember-test-helpers itself is only published to bower, and it's published without a build step, and klassy is currently a bower dependency. What is the ideal configuration you're looking for here?

the goal is 100% NPM installs to enable the cut over from bower.

cc @chadhietala

@dgeb
Copy link
Member

dgeb commented Jun 9, 2015

the goal is 100% NPM installs to enable the cut over from bower.

by June 12?

@chadhietala
Copy link
Contributor

@dgeb Negative.

@stefanpenner
Copy link
Member Author

the goal is 100% NPM installs to enable the cut over from bower.
by June 12?

by asap :P

@dgeb dgeb mentioned this issue Jun 9, 2015
@dgeb
Copy link
Member

dgeb commented Jun 9, 2015

Since klassy is no longer a blocker here, I'm closing in favor of #58.

@dgeb dgeb closed this as completed Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants